mqtt: improve rule support for detection #11995
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11995 +/- ##
==========================================
+ Coverage 82.75% 83.40% +0.64%
==========================================
Files 910 910
Lines 249016 257618 +8602
==========================================
+ Hits 206069 214855 +8786
+ Misses 42947 42763 -184
Flags with carried forward coverage won't be shown. Click here to find out more. |
jufajardini
reviewed
Oct 24, 2024
Absolutely, working on it right now -- will then update this PR and open it for review. |
satta
changed the title
|
Removed draft status. |
jufajardini
approved these changes
Oct 25, 2024
victorjulien
approved these changes
Nov 4, 2024
Merged
|
Merged in #12088, thanks! |
|
Thanks @satta :-) |
|
Thanks for finding these! 🤝 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Link to ticket: https://redmine.openinfosecfoundation.org/issues/7323
Describe changes:
SV_REPO=
SV_BRANCH=OISF/suricata-verify#2106
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=